-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NextJS Codegen #1346
base: canary
Are you sure you want to change the base?
NextJS Codegen #1346
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Generated with ❤️ by ellipsis.dev |
3b09c1e
to
922ac1c
Compare
2f0579f
to
43eb31f
Compare
210977c
to
0219ef1
Compare
04e9f20
to
f758959
Compare
f758959
to
c75e1a0
Compare
c75e1a0
to
ea9b375
Compare
ea9b375
to
743bf9c
Compare
43628df
to
e4e9830
Compare
e4e9830
to
d28aa93
Compare
d28aa93
to
f2dbc25
Compare
083d7db
to
b8c5100
Compare
b8c5100
to
95d6961
Compare
95d6961
to
375e20b
Compare
engine/language_client_codegen/baml_src/baml_client/__init__.py
Outdated
Show resolved
Hide resolved
f9b90cf
to
ea6f658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments, none of them critical.
Looks pretty great!
Note - I haven't run integ tests myself.
I did run pnpm generate
but didn't carefully examine the results.
Happy to do the above things soon, just wanted to give my initial 👍 in case you are trying to merge quickly.
engine/language_client_typescript/artifacts/async_context_vars.d.ts.map
Outdated
Show resolved
Hide resolved
feat: added nextjs-plugin package for quick next.js config setup feat: add codelens for react
feat: updated ref docs for python, ruby, openapi, and typescript
7f7937d
to
7d28e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reading docs now
import type { Checked, Check } from "./types" | ||
import type { {% for t in types %} {{ t }}{% if !loop.last %}, {% endif %}{% endfor %} } from "./types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a name collision, that users can't use "Check" for their own type name - or is that a decision we already made? (Same also applies to "Image" and "Audio", but I think that one is less egregious.)
cc @imalsogreg
@@ -5,6 +5,6 @@ if (require.main === module) { | |||
process.env.BAML_LOG = 'info' | |||
} | |||
|
|||
const baml = require('./native') | |||
const baml = require('./artifacts/native') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this change out of this PR?
I tried to do something along these lines a while back and screwed up the TS release in a hard-to-understand way. We can try another PR to push this forward but I'm uncomfortable doing that in this PR.
npm install @boundaryml/baml | ||
npm install @boundaryml/baml-nextjs-plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install @boundaryml/baml | |
npm install @boundaryml/baml-nextjs-plugin | |
npm install @boundaryml/baml @boundaryml/baml-nextjs-plugin |
and I think we can do the same for the others too?
This adds native integration for next.js code generation.